cptbox: support subprocess.STDOUT
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DMOJ#958, see https://dmoj.ca/submission/3963487 (patched) versus https://dmoj.ca/submission/3963488 (unpatched).
Xyene
force-pushed
the
support-more-stream-types
branch
from
dbd443b to
5786fce
Compare
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 138 138
Lines 4735 4737 +2
=======================================
+ Hits 4092 4094 +2
Misses 643 643
Continue to review full report at Codecov.
|
Ref DMOJ#958. For some reason, fpc crashes during compile errors if this is specified, despite never writing to stdout if it isn't.
Xyene
force-pushed
the
support-more-stream-types
branch
from
859da67 to
e335034
Compare
quantum5
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958, see https://dmoj.ca/submission/3963487 (patched) versus
https://dmoj.ca/submission/3963488 (unpatched).